From ae8f2d2058b15a36355f2d16d3deb336a30d13e7 Mon Sep 17 00:00:00 2001
From: tompetrus <tom.petrus.be@gmail.com>
Date: Fri, 20 May 2016 16:29:56 +0200
Subject: [PATCH] Bugfix add1xml

When the length of p_xml would be an exact multitude of 4000 the loop
over chunks would execute one time too much, causing "ORA-06502: PLSQL:
numeric of value error: invalid LOB locator specified: ORA-22275",
because the second part of dbms_lob.append would be NULL. A check is
added on the length of the clob and if if the mod of 4000 is zero, we
decrease the amount of loops by one.
---
 ora/xlsx_builder_pkg.pkb | 35 +++++++++++++++++++++--------------
 1 file changed, 21 insertions(+), 14 deletions(-)

diff --git a/ora/xlsx_builder_pkg.pkb b/ora/xlsx_builder_pkg.pkb
index 064c19b..ae28410 100755
--- a/ora/xlsx_builder_pkg.pkb
+++ b/ora/xlsx_builder_pkg.pkb
@@ -774,22 +774,29 @@ as
     workbook.sheets( t_sheet ).autofilters( t_ind ).row_end := p_row_end;
   end;
 --
-  procedure add1xml
-    ( p_excel in out nocopy blob
-    , p_filename varchar2
-    , p_xml clob
-    )
-  is
+  procedure add1xml 
+    ( p_excel in out nocopy blob 
+    , p_filename varchar2 
+    , p_xml clob 
+    ) 
+  is 
     t_tmp blob;
-  begin
+    l_count binary_integer;
+  begin  
     dbms_lob.createtemporary( t_tmp, true );
-    for i in 0 .. trunc( length( p_xml ) / 4000 )
-    loop
-      dbms_lob.append( t_tmp, utl_i18n.string_to_raw( substr( p_xml, i * 4000 + 1, 4000 ), 'AL32UTF8' ) );
-    end loop;
-    add1file( p_excel, p_filename, t_tmp );
-    dbms_lob.freetemporary( t_tmp );
-  end;
+    l_count := trunc( length( p_xml ) / 4000 );
+    
+    if mod( length( p_xml ), 4000 ) = 0 then
+      l_count := greatest(l_count - 1, 0);
+    end if;
+    
+    for i in 0 .. l_count
+    loop 
+      dbms_lob.append( t_tmp, utl_i18n.string_to_raw( substr( p_xml, i * 4000 + 1, 4000 ),  'AL32UTF8') ); 
+    end loop; 
+    add1file( p_excel, p_filename, t_tmp ); 
+    dbms_lob.freetemporary( t_tmp ); 
+  end; 
 --
   function finish
   return blob