1 line
4.1 KiB
JSON
1 line
4.1 KiB
JSON
{"schema_version":"1.9.0","id":"GHSA-45m3-398w-m2m9","published":"2026-03-02T21:41:36Z","modified":"2026-03-23T04:56:02.918420742Z","aliases":["CVE-2026-28789","GO-2026-4586"],"summary":"OliveTin has unauthenticated DoS via concurrent map writes in OAuth2 state handling","details":"### Summary\nAn unauthenticated denial-of-service vulnerability exists in OliveTin’s OAuth2 login flow. Concurrent requests to /oauth/login can trigger unsynchronized access to a shared registeredStates map, causing a Go runtime panic (fatal\n error: concurrent map writes) and process termination. This allows remote attackers to crash the service when OAuth2 is enabled.\n\n\n### Details\nThe OAuth2 handler stores per-login state in a shared map without synchronization:\n\n - service/internal/auth/otoauth2/restapi_auth_oauth2.go:24\n registeredStates map[string]*oauth2State\n - Unlocked write in login handler: .../restapi_auth_oauth2.go:141\n - Unlocked read in callback check: .../restapi_auth_oauth2.go:174\n - Unlocked writes in callback flow: .../restapi_auth_oauth2.go:284-285\n - Unlocked read in auth chain check: .../restapi_auth_oauth2.go:376\n\n These paths are network reachable via publicly registered routes:\n```bash\n - service/internal/httpservers/frontend.go:71 → /oauth/login\n - service/internal/httpservers/frontend.go:72 → /oauth/callback\n```\n Because Go HTTP handlers run concurrently, high parallel traffic to /oauth/login causes concurrent map access and runtime panic.\n\n Tested on:\n\n - Container image: ghcr.io/olivetin/olivetin:3000.10.0\n - Source also contains same pattern at commit/tag eb42029b5d0c0633551621288180dd4566b913f7 (3000.10.1)\n\n\n### PoC\n1. Start OliveTin with OAuth2 provider configured (example github), exposing port 1337.\n 2. Confirm baseline:\n```bash\n curl -i http://127.0.0.1:1337/readyz\n curl -i \"http://127.0.0.1:1337/oauth/login?provider=github\"\n```\n Expected: 200 for /readyz, 302 for /oauth/login.\n\n 3. Run concurrency PoC:\n```bash\n python3 /OliveTin/tools/poc_oauth2_state_map_race_dos.py \\\n --base-url http://127.0.0.1:1337 \\\n --provider github \\\n --workers 80 \\\n --requests 120000 \\\n --health-failures 3\n```\n 4. Verify crash:\n\n docker inspect olivetin-dos --format 'status={{.State.Status}} exit={{.State.ExitCode}}'\n docker logs olivetin-dos 2>&1 | grep -E \"fatal error: concurrent map|concurrent map writes|restapi_auth_oauth2.go\"\n\n Observed result:\n\n - Process exited with code 2\n - Logs include:\n - fatal error: concurrent map writes\n - .../internal/auth/otoauth2/restapi_auth_oauth2.go:141 in HandleOAuthLogin\n\n\n\n### Impact\n- Vulnerability type: Race condition (CWE-362) leading to DoS.\n - Attacker requirements: network access only; no authentication required for exploit path.\n - Impacted deployments: OliveTin instances with OAuth2 enabled and reachable over network.\n - Security impact: remote unauthenticated attacker can repeatedly crash OliveTin, causing availability loss until restart/recovery.\n \n[poc_oauth2_state_map_race_dos.py](https://github.com/user-attachments/files/25577901/poc_oauth2_state_map_race_dos.py)","affected":[{"package":{"name":"github.com/OliveTin/OliveTin","ecosystem":"Go","purl":"pkg:golang/github.com/OliveTin/OliveTin"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"0.0.0-20260301235225-f044d90d5525c"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/03/GHSA-45m3-398w-m2m9/GHSA-45m3-398w-m2m9.json"}}],"references":[{"type":"WEB","url":"https://github.com/OliveTin/OliveTin/security/advisories/GHSA-45m3-398w-m2m9"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-28789"},{"type":"WEB","url":"https://github.com/OliveTin/OliveTin/commit/f044d90d5525c4c8e3f421b32ed7eff771c22d36"},{"type":"PACKAGE","url":"https://github.com/OliveTin/OliveTin"}],"database_specific":{"cwe_ids":["CWE-362","CWE-400","CWE-662"],"github_reviewed":true,"github_reviewed_at":"2026-03-02T21:41:36Z","nvd_published_at":"2026-03-05T20:16:16Z","severity":"HIGH"},"severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}]} |