HackBase/python-cx_Oracle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Eliminate memory leak when extending a collection.

Browse Source
This commit is contained in:
Anthony Tuininga 2018-03-02 13:17:21 -07:00
parent 9264805596
commit e08e23bb93
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cxoObject.c
View File

@ -317,16 +317,18 @@ int cxoObject_internalExtend(cxoObject *obj, PyObject *sequence)
PyObject *fastSequence, *element;
Py_ssize_t size, i;
// append each of the items in the sequence to the collection
fastSequence = PySequence_Fast(sequence, "expecting sequence");
if (!fastSequence)
return -1;
size = PySequence_Fast_GET_SIZE(fastSequence);
for (i = 0; i < size; i++) {
element = PySequence_Fast_GET_ITEM(fastSequence, i);
if (cxoObject_internalAppend(obj, element) < 0)
if (cxoObject_internalAppend(obj, element) < 0) {
Py_DECREF(fastSequence);
return -1;
}
}
Py_DECREF(fastSequence);
return 0;
}