HackBase/python-cx_Oracle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent use of NaN with Oracle numbers since it produces corrupt data

Browse Source 
(https://github.com/oracle/python-cx_Oracle/issues/91).
This commit is contained in:
Anthony Tuininga 2017-11-15 11:48:17 -07:00
parent 9311ab9c4e
commit c5fab177f9
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Transforms.c
View File

@ -248,6 +248,12 @@ static int PythonFloatToOracleNumber(
sword status; sword status;
doubleValue = PyFloat_AS_DOUBLE(pythonValue); doubleValue = PyFloat_AS_DOUBLE(pythonValue);
if (isnan(doubleValue)) {
PyErr_SetString(g_DatabaseErrorException,
"value is not a number (NaN) and cannot be used in Oracle "
"numbers");
return -1;
}
status = OCINumberFromReal(environment->errorHandle, &doubleValue, status = OCINumberFromReal(environment->errorHandle, &doubleValue,
sizeof(double), oracleValue); sizeof(double), oracleValue);
return Environment_CheckForError(environment, status, return Environment_CheckForError(environment, status,

8
src/cx_Oracle.c
View File

@ -18,10 +18,18 @@
#include <datetime.h> #include <datetime.h>
#include <structmember.h> #include <structmember.h>
#include <time.h> #include <time.h>
#include <math.h>
#include <oci.h> #include <oci.h>
#include <orid.h> #include <orid.h>
#include <xa.h> #include <xa.h>
// define isnan for older versions of Visual Studio which only define _isnan
#ifdef _WIN32
#ifndef isnan
#define isnan _isnan
#endif
#endif
// validate OCI library // validate OCI library
#if !defined(OCI_MAJOR_VERSION) || (OCI_MAJOR_VERSION < 11) || \ #if !defined(OCI_MAJOR_VERSION) || (OCI_MAJOR_VERSION < 11) || \
((OCI_MAJOR_VERSION == 11) && (OCI_MINOR_VERSION < 2)) ((OCI_MAJOR_VERSION == 11) && (OCI_MINOR_VERSION < 2))