From 2737ae2f125330aa9cd8e37257307becb0d25c91 Mon Sep 17 00:00:00 2001 From: Anthony Tuininga Date: Thu, 2 Oct 2008 17:09:47 +0000 Subject: [PATCH] Clean up checking for platform and versions when checking for bdist_wininst and bdist_msi - initial patch supplied by Amaury Forgeot d'Arc. --- setup.py | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/setup.py b/setup.py index 02f68a9..35157ac 100644 --- a/setup.py +++ b/setup.py @@ -10,10 +10,15 @@ Unix platforms import sys -if sys.platform == "win32": - if sys.version_info[:2] >= (2, 5): - import distutils.command.bdist_msi +import distutils.command +try: + import distutils.command.bdist_msi +except ImportError: + distutils.command.bdist_msi = None +try: import distutils.command.bdist_wininst +except ImportError: + distutils.command.bdist_wininst = None import distutils.command.bdist_rpm import distutils.command.build import distutils.dist @@ -231,20 +236,20 @@ class build(distutils.command.build.build): commandClasses = dict(build = build, bdist_rpm = bdist_rpm) # tweak the Windows installer names to include the Oracle version -if sys.platform == "win32": - - if sys.version_info[:2] >= (2, 5): +if distutils.command.bdist_msi is not None: - class bdist_msi(distutils.command.bdist_msi.bdist_msi): + class bdist_msi(distutils.command.bdist_msi.bdist_msi): - def run(self): - origMethod = self.distribution.get_fullname - self.distribution.get_fullname = \ - self.distribution.get_fullname_with_oracle_version - distutils.command.bdist_msi.bdist_msi.run(self) - self.distribution.get_fullname = origMethod + def run(self): + origMethod = self.distribution.get_fullname + self.distribution.get_fullname = \ + self.distribution.get_fullname_with_oracle_version + distutils.command.bdist_msi.bdist_msi.run(self) + self.distribution.get_fullname = origMethod - commandClasses["bdist_msi"] = bdist_msi + commandClasses["bdist_msi"] = bdist_msi + +if distutils.command.bdist_wininst is not None: class bdist_wininst(distutils.command.bdist_wininst.bdist_wininst):