HackBase/CORE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of DML Err view, process tables directly

Browse Source
This commit is contained in:
Jan Kvetina 2022-02-06 21:19:01 +01:00
parent a8e19cdff2
commit 7e9102182f
3 changed files with 78 additions and 147 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/app.spec.sql
View File

@ -81,7 +81,6 @@ CREATE OR REPLACE PACKAGE app AS
dml_tables_owner CONSTANT VARCHAR2(30) := NULL; -- NULL = same as current owner
dml_tables_prefix CONSTANT VARCHAR2(30) := ''; -- ERR$
dml_tables_postfix CONSTANT VARCHAR2(30) := '_E$';
view_dml_errors CONSTANT VARCHAR2(30) := 'LOGS_DML_ERRORS';
-- translations
transl_item_prefix CONSTANT VARCHAR2(30) := 'T';
@ -1405,13 +1404,6 @@ CREATE OR REPLACE PACKAGE app AS
--
-- Merge all DML error tables (_E$) into single view
--
PROCEDURE create_dml_errors_view;
--
-- Maps existing DML errors to proper row in LOGS table
--

210
packages/app.sql
View File

@ -734,6 +734,8 @@ CREATE OR REPLACE PACKAGE BODY app AS
--
app.log_success(recent_request_id);
--
-- log_warning for long page loads
--
COMMIT;
EXCEPTION
WHEN app.app_exception THEN
@ -3407,8 +3409,18 @@ CREATE OR REPLACE PACKAGE BODY app AS
-- drop existing tables
app.drop_dml_table(in_table_name);
--
IF app.get_dml_table(in_table_name) IS NULL THEN
RETURN;
END IF;
-- create DML log tables for all tables
-- create DML log table
--
IF app.is_debug_on() THEN
app.log_debug('DML', app.get_owner(app.get_app_id()) || '.' || in_table_name);
app.log_debug('ERR', app.get_owner(app.get_app_id()), app.get_dml_table(in_table_name));
END IF;
--
DBMS_ERRLOG.CREATE_ERROR_LOG (
dml_table_name => app.get_owner(app.get_app_id()) || '.' || in_table_name,
err_log_table_owner => app.get_owner(app.get_app_id()),
@ -3432,98 +3444,6 @@ CREATE OR REPLACE PACKAGE BODY app AS
PROCEDURE create_dml_errors_view
AS
q_block VARCHAR2(32767);
q CLOB;
comments DBMS_UTILITY.LNAME_ARRAY; -- TABLE OF VARCHAR2(4000) INDEX BY BINARY_INTEGER;
BEGIN
app.log_module();
--
DBMS_LOB.CREATETEMPORARY(q, TRUE);
-- backup view columns comments
FOR c IN (
SELECT table_name, column_name, comments
FROM user_col_comments
WHERE table_name = app.view_dml_errors
) LOOP
comments(comments.count) :=
'COMMENT ON COLUMN ' || c.table_name || '.' || c.column_name ||
' IS ''' || REPLACE(c.comments, '''', '''''') || '''';
END LOOP;
-- create header with correct data types
q_block := q_block || 'CREATE OR REPLACE VIEW ' || app.view_dml_errors || ' AS' || CHR(10);
q_block := q_block || 'SELECT' || CHR(10);
q_block := q_block || ' --' || CHR(10);
q_block := q_block || ' -- THIS VIEW IS GENERATED' || CHR(10);
q_block := q_block || ' --' || CHR(10);
q_block := q_block || ' 0 AS log_id,' || CHR(10);
q_block := q_block || ' ''-'' AS operation,' || CHR(10);
q_block := q_block || ' ''-'' AS table_name,' || CHR(10);
q_block := q_block || ' ''UROWID'' AS table_rowid,' || CHR(10);
q_block := q_block || ' ROWID AS dml_rowid,' || CHR(10);
q_block := q_block || ' ''-'' AS error_message,' || CHR(10);
q_block := q_block || ' ''-'' AS json_data' || CHR(10);
q_block := q_block || 'FROM DUAL' || CHR(10);
q_block := q_block || 'WHERE ROWNUM = 0' || CHR(10);
--
DBMS_LOB.WRITEAPPEND(q, LENGTH(q_block), q_block);
q_block := '';
-- append all existing tables
FOR c IN (
SELECT
t.table_name AS data_table,
a.table_name AS error_table,
--
LISTAGG(c.column_name, ', ') WITHIN GROUP (ORDER BY c.column_id) AS list_columns
FROM user_tables t
JOIN all_tables a
ON a.owner = COALESCE(app.dml_tables_owner, app.get_owner(app.get_app_id()))
AND a.owner || '.' || a.table_name = app.get_dml_table(t.table_name)
JOIN all_tab_cols c
ON c.owner = a.owner
AND c.table_name = a.table_name
AND c.column_name NOT LIKE 'ORA_ERR_%$'
GROUP BY t.table_name, a.table_name
ORDER BY 1
) LOOP
app.log_result(c.data_table, c.error_table);
--
q_block := 'UNION ALL' || CHR(10);
q_block := q_block || 'SELECT' || CHR(10);
q_block := q_block || ' TO_NUMBER(t.ora_err_tag$),' || CHR(10);
q_block := q_block || ' t.ora_err_optyp$,' || CHR(10);
q_block := q_block || ' ''' || c.data_table || ''',' || CHR(10);
q_block := q_block || ' CAST(t.ora_err_rowid$ AS VARCHAR2(30)),' || CHR(10);
q_block := q_block || ' t.ROWID,' || CHR(10);
q_block := q_block || ' t.ora_err_mesg$,' || CHR(10);
--
q_block := q_block || ' JSON_OBJECT(' || c.list_columns || ' ABSENT ON NULL)' || CHR(10);
q_block := q_block || 'FROM ' || c.error_table || ' t' || CHR(10);
--
DBMS_LOB.WRITEAPPEND(q, LENGTH(q_block), q_block);
END LOOP;
--
EXECUTE IMMEDIATE q;
-- add comments
FOR i IN comments.FIRST .. comments.LAST LOOP
EXECUTE IMMEDIATE comments(i);
END LOOP;
--
app.log_success();
EXCEPTION
WHEN app.app_exception THEN
RAISE;
WHEN OTHERS THEN
app.raise_error();
END;
PROCEDURE process_dml_errors (
in_table_name user_tables.table_name%TYPE := NULL
)
@ -3538,51 +3458,77 @@ CREATE OR REPLACE PACKAGE BODY app AS
json_data VARCHAR2(4000)
);
rec log_dml_error; -- logs_dml_errors%ROWTYPE; avoid references
--
r SYS_REFCURSOR;
q VARCHAR2(32767);
BEGIN
IF app.is_debug_on() THEN
app.log_module(in_table_name);
END IF;
-- dynamic query to avoid references to avoid recompilation errors on APP package
OPEN r FOR
'SELECT * FROM ' || view_dml_errors ||
CASE WHEN in_table_name IS NOT NULL
THEN ' WHERE table_name = ''' || in_table_name || '''' END;
app.log_module(in_table_name);
--
LOOP
FETCH r INTO rec;
EXIT WHEN r%NOTFOUND;
--
app.log_error (
in_action_name => 'DML_ERROR',
in_arg1 => rec.operation,
in_arg2 => rec.table_name,
in_arg3 => rec.table_rowid,
in_arg4 => rec.dml_rowid,
in_arg5 => rec.error_message,
in_arg6 => rec.json_data,
in_parent_id => rec.log_id,
FOR c IN (
SELECT
t.table_name AS data_table,
a.table_name AS error_table,
--
in_payload => app.get_dml_query (
in_log_id => rec.log_id,
in_table_name => rec.table_name,
in_table_rowid => rec.table_rowid,
in_operation => rec.operation
) || CHR(10) || '--' || CHR(10)
);
-- remove from DML ERR table
EXECUTE IMMEDIATE
'DELETE FROM ' || app.get_dml_table(rec.table_name) ||
' WHERE ora_err_tag$ = :id'
USING rec.log_id;
LISTAGG(c.column_name, ', ') WITHIN GROUP (ORDER BY c.column_id) AS list_columns
FROM user_tables t
JOIN all_tables a
ON a.owner = COALESCE(app.dml_tables_owner, app.get_owner(app.get_app_id()))
AND a.table_name = app.get_dml_table(t.table_name)
AND a.table_name != t.table_name
JOIN all_tab_cols c
ON c.owner = a.owner
AND c.table_name = a.table_name
AND c.column_name NOT LIKE 'ORA_ERR_%$'
WHERE t.table_name = NVL(in_table_name, t.table_name)
GROUP BY t.table_name, a.table_name
ORDER BY 1
) LOOP
app.log_result(c.data_table, c.error_table);
--
q := 'SELECT' || CHR(10);
q := q || ' TO_NUMBER(t.ora_err_tag$),' || CHR(10);
q := q || ' t.ora_err_optyp$,' || CHR(10);
q := q || ' ''' || c.data_table || ''',' || CHR(10);
q := q || ' CAST(t.ora_err_rowid$ AS VARCHAR2(30)),' || CHR(10);
q := q || ' t.ROWID,' || CHR(10);
q := q || ' t.ora_err_mesg$,' || CHR(10);
q := q || ' JSON_OBJECT(' || c.list_columns || ' ABSENT ON NULL)' || CHR(10);
q := q || 'FROM ' || c.error_table || ' t';
--
OPEN r FOR q;
LOOP
FETCH r INTO rec;
EXIT WHEN r%NOTFOUND;
--
app.log_error (
in_action_name => 'DML_ERROR',
in_arg1 => rec.operation,
in_arg2 => rec.table_name,
in_arg3 => rec.table_rowid,
in_arg4 => rec.dml_rowid,
in_arg5 => rec.error_message,
in_arg6 => rec.json_data,
in_parent_id => rec.log_id,
--
in_payload => app.get_dml_query (
in_log_id => rec.log_id,
in_table_name => rec.table_name,
in_table_rowid => rec.table_rowid,
in_operation => rec.operation
) || CHR(10) || '--' || CHR(10)
);
-- remove from DML ERR table
EXECUTE IMMEDIATE
'DELETE FROM ' || app.get_dml_table(rec.table_name) ||
' WHERE ora_err_tag$ = :id'
USING rec.log_id;
END LOOP;
--
CLOSE r;
END LOOP;
CLOSE r;
--
IF app.is_debug_on() THEN
app.log_success();
END IF;
app.log_success();
EXCEPTION
WHEN app.app_exception THEN
RAISE;

7
packages/app_actions.sql
View File

@ -732,7 +732,6 @@ CREATE OR REPLACE PACKAGE BODY app_actions AS
in_is_read_only obj_tables.is_read_only%TYPE := NULL,
in_comments obj_tables.comments%TYPE := NULL
) AS
v_err_dml_changed BOOLEAN;
BEGIN
app.log_module(in_table_name, in_table_group, in_is_dml_handler, in_is_row_mov, in_is_read_only, in_comments);
--
@ -767,15 +766,9 @@ CREATE OR REPLACE PACKAGE BODY app_actions AS
ELSIF in_is_dml_handler IS NULL THEN
app.drop_dml_table(in_table_name);
END IF;
--
v_err_dml_changed := TRUE;
END IF;
END LOOP;
--
IF v_err_dml_changed THEN
app.create_dml_errors_view();
END IF;
--
app.log_success();
EXCEPTION
WHEN app.app_exception THEN