From 4592ff5bb9c1da8e12767c3ff1004ddcea01d150 Mon Sep 17 00:00:00 2001
From: Jan Kvetina <jan.kvetina@gmail.com>
Date: Sat, 29 Jan 2022 09:12:40 +0100
Subject: [PATCH] Links as/thru function

---
 packages/app_actions.spec.sql     | 12 ++++++++++++
 packages/app_actions.sql          | 13 +++++++++++++
 views/nav_overview.sql            |  4 ++--
 views/obj_constraints_fix_dt2.sql |  2 +-
 views/obj_views.sql               | 10 +++++-----
 5 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/packages/app_actions.spec.sql b/packages/app_actions.spec.sql
index d4932ea..c6154b0 100644
--- a/packages/app_actions.spec.sql
+++ b/packages/app_actions.spec.sql
@@ -60,6 +60,18 @@ CREATE OR REPLACE PACKAGE app_actions AS
 
 
 
+    --
+    -- Get HTML alement A
+    --
+    FUNCTION get_html_a (
+        in_href                 VARCHAR2,
+        in_name                 VARCHAR2,
+        in_title                VARCHAR2    := NULL
+    )
+    RETURN VARCHAR2;
+
+
+
     -- ### Navigation page
     --
 
diff --git a/packages/app_actions.sql b/packages/app_actions.sql
index 646a294..0b17877 100644
--- a/packages/app_actions.sql
+++ b/packages/app_actions.sql
@@ -18,6 +18,19 @@ CREATE OR REPLACE PACKAGE BODY app_actions AS
 
 
 
+    FUNCTION get_html_a (
+        in_href                 VARCHAR2,
+        in_name                 VARCHAR2,
+        in_title                VARCHAR2    := NULL
+    )
+    RETURN VARCHAR2
+    AS
+    BEGIN
+        RETURN '<a href="' || in_href || '" title="' || in_title ||'">' || in_name || '</a>';
+    END;
+
+
+
     PROCEDURE nav_remove_pages (
         in_page_id              navigation.page_id%TYPE         := NULL
     )
diff --git a/views/nav_overview.sql b/views/nav_overview.sql
index bed4a4f..105f715 100644
--- a/views/nav_overview.sql
+++ b/views/nav_overview.sql
@@ -84,12 +84,12 @@ SELECT
             THEN app.get_icon('fa-check-square', 'MUST_NOT_BE_PUBLIC_USER')
         WHEN t.authorization_scheme IS NULL AND n.page_id NOT IN (0, 9999)
             THEN app.get_icon('fa-warning', 'Auth scheme is missing')
-        ELSE '<a href="' || app.get_page_link (
+        ELSE app_actions.get_html_a(app.get_page_link (
             in_page_id      => 920,
             in_app_id       => n.app_id,
             in_names        => 'P920_AUTH_SCHEME',
             in_values       => t.authorization_scheme
-        ) || '">' || t.authorization_scheme || '</a>'
+        ), t.authorization_scheme)
         END AS auth_scheme,
     --
     CASE WHEN n.page_id > 0 AND r.page_id IS NULL
diff --git a/views/obj_constraints_fix_dt2.sql b/views/obj_constraints_fix_dt2.sql
index d6e3252..52519b9 100644
--- a/views/obj_constraints_fix_dt2.sql
+++ b/views/obj_constraints_fix_dt2.sql
@@ -40,7 +40,7 @@ FROM (
         s.column_name,
         s.data_type,
         --
-        LISTAGG('<a href="' || app_actions.get_object_link('TABLE', s.table_name) || '">' || s.table_name || '</a>', ', ')
+        LISTAGG(app_actions.get_html_a(app_actions.get_object_link('TABLE', s.table_name), s.table_name), ', ')
             WITHIN GROUP (ORDER BY s.table_name) AS tables,
         --
         LISTAGG('ALTER TABLE ' || LOWER(s.table_name) ||
diff --git a/views/obj_views.sql b/views/obj_views.sql
index 06a76c5..2cb20e2 100644
--- a/views/obj_views.sql
+++ b/views/obj_views.sql
@@ -15,12 +15,12 @@ r AS (
         d.name          AS view_name,
         --
         LISTAGG(CASE WHEN d.referenced_type = 'TABLE'
-            THEN '<a href="' || app_actions.get_object_link(d.referenced_type, d.referenced_name) || '">' || d.referenced_name || '</a>' END, ', ')
+            THEN app_actions.get_html_a(app_actions.get_object_link(d.referenced_type, d.referenced_name), d.referenced_name) END, ', ')
             WITHIN GROUP (ORDER BY d.referenced_name)
             AS referenced_tables,
         --
         LISTAGG(CASE WHEN d.referenced_type = 'VIEW'
-            THEN '<a href="' || app_actions.get_object_link(d.referenced_type, d.referenced_name) || '">' || d.referenced_name || '</a>' END, ', ')
+            THEN app_actions.get_html_a(app_actions.get_object_link(d.referenced_type, d.referenced_name), d.referenced_name) END, ', ')
             WITHIN GROUP (ORDER BY d.referenced_name)
             AS referenced_views
     FROM user_dependencies d
@@ -34,7 +34,7 @@ u AS (
     SELECT
         d.referenced_name AS view_name,
         --
-        LISTAGG('<a href="' || app_actions.get_object_link(d.type, d.name) || '">' || d.name || '</a>', ', ')
+        LISTAGG(app_actions.get_html_a(app_actions.get_object_link(d.type, d.name), d.name), ', ')
             WITHIN GROUP (ORDER BY d.name) AS used_in_objects
     FROM user_dependencies d
     WHERE d.referenced_type     = 'VIEW'
@@ -43,11 +43,11 @@ u AS (
 p AS (
     SELECT
         r.table_name,
-        LISTAGG(DISTINCT '<a href="' ||
+        LISTAGG(DISTINCT app_actions.get_html_a (
             app.get_page_link(910,
                 in_names    => 'P910_PAGE_ID',
                 in_values   => r.page_id
-            ) || '">' || r.page_id || '</a>', ', ')
+            ), r.page_id), ', ')
             WITHIN GROUP (ORDER BY r.page_id) AS used_on_pages
     FROM apex_application_page_regions r
     JOIN x